Skip to content

DOC Fix EX01 in docstrings - added examples #52158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2023

Conversation

DeaMariaLeon
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Towards #37875

@mroeschke mroeschke added the Docs label Mar 24, 2023
@DeaMariaLeon
Copy link
Member Author

I removed:
assert Series.hasnans.__doc__ == Index.hasnans.__doc__ from test.

The docstrings are not the same with the examples I added - or do I have to make a shared doc?

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Mar 25, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @DeaMariaLeon (I think it's fine for the docstrings to slightly differ)

@MarcoGorelli MarcoGorelli merged commit 6c50f70 into pandas-dev:main Mar 25, 2023
@DeaMariaLeon DeaMariaLeon deleted the example branch March 25, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants