PERF: concat_compat #52316
Merged
PERF: concat_compat #52316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Mar 31, 2023
| elif axis == 0: | ||
| return obj._concat_same_type(to_concat_eas) | ||
| else: | ||
| # e.g. DatetimeArray |
There was a problem hiding this comment.
Can we get here with EAs with _concat_same_type without the axis keyword e.g. Sparse?
There was a problem hiding this comment.
No, we only get here (axis=1) from internals.concat, and there pass ea_compat_axis=True in those cases
mroeschke
added
Performance
mroeschke
approved these changes
Mar 31, 2023
|
Thanks @jbrockmendel |
|
@jbrockmendel I think there might be typing failures here. Mind taking a look? https://github.com/pandas-dev/pandas/actions/runs/4578025660/jobs/8084134007 |
|
yep, will make a PR shortly |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastpath for all-matching-dtype case.