TYP: Fix type hint for params passed to read_sql_query #52357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tolker-KU
changed the title
Tolker-KU
force-pushed
the
feature/read_sql_type_hint
branch
from
9a34687 to
d52575d
Compare
mroeschke
reviewed
Apr 3, 2023
mroeschke
reviewed
Apr 3, 2023
| @@ -357,7 +358,7 @@ def read_sql_query( | |||
| con, | |||
| index_col: str | list[str] | None = ..., | |||
| coerce_float=..., | |||
| params: list[str] | dict[str, str] | None = ..., | |||
| params: list[Any] | Mapping[str, Any] | None = ..., | |||
There was a problem hiding this comment.
Can the Any been made more specific?
There was a problem hiding this comment.
I think this is one of the rare cases where Any is correct. See the type hint in SQLAlchemy which we are calling into here:
https://github.com/sqlalchemy/sqlalchemy/blob/e79ab08165e01dc7af50fcffadb31468ace51b6c/lib/sqlalchemy/engine/base.py#L1370-L1376
https://github.com/sqlalchemy/sqlalchemy/blob/e79ab08165e01dc7af50fcffadb31468ace51b6c/lib/sqlalchemy/engine/interfaces.py#L224-L229
mroeschke
added
IO SQL
Tolker-KU
force-pushed
the
feature/read_sql_type_hint
branch
from
d52575d to
20ed8ad
Compare
|
CI failed due to a GitHub issue. Can someone rerun the checks? |
mroeschke
approved these changes
Apr 10, 2023
|
Thanks @Tolker-KU |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.