Skip to content

CLN/TST: Clean groupby.test_allowlist #52537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2023

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

The allowlist has been removed, so this test file should be cleaned up. Renamed test_api_consistency to test_api so we can group some of these tests. The tests that remain in test_allowlist are likely duplicates of other tests and can probably be removed. Will look to do so in a followup.

@rhshadrach rhshadrach added Testing pandas testing functions or related to the test suite Groupby Clean labels Apr 8, 2023
@topper-123 topper-123 added this to the 2.1 milestone Apr 9, 2023
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's not a lot left in test_allowlist. Can the remaining tests be moved to other locations?

@topper-123 topper-123 merged commit e9e034b into pandas-dev:main Apr 9, 2023
@topper-123
Copy link
Contributor

thanks @rhshadrach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants