Skip to content

Add test for MultiIndex.from_tuples #52560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pandas/tests/indexing/multiindex/test_multiindex.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,3 +206,8 @@ def test_multiindex_with_na_missing_key(self):
)
with pytest.raises(KeyError, match="missing_key"):
df[[("missing_key",)]]

def test_multiindex_from_tuples_with_nan(self):
# GH#23578
multi_idx = MultiIndex.from_tuples([("a", "b", "c"), np.nan, ("d", "", "")])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
multi_idx = MultiIndex.from_tuples([("a", "b", "c"), np.nan, ("d", "", "")])
result = MultiIndex.from_tuples([("a", "b", "c"), np.nan, ("d", "", "")])

assert isinstance(multi_idx, MultiIndex)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you construct

expected = MultiIndex.from_tuples([("a", "b", "c"), (np.nan, np.nan, np.nan), ("d", "", "")])

and then call

tm.assert_index_equal_result, expected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done