DEPR: is_datetime64tz_dtype, is_interval_dtype #52607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 12, 2023
| @@ -319,6 +319,13 @@ def is_datetime64tz_dtype(arr_or_dtype) -> bool: | |||
| >>> is_datetime64tz_dtype(s) | |||
| True | |||
| """ | |||
| # GH#52607 | |||
| warnings.warn( | |||
| "is_datetime64tz_dtype is deprecated and will be removed in a future " | |||
There was a problem hiding this comment.
This could be useful if we want to check whether it's a numpy or arrow tz type, but idk if we have a use case for that yet.
There was a problem hiding this comment.
It could. I think the fact that it is ambiguous (based on the name) is all the more reason to deprecate it
mroeschke
approved these changes
Apr 12, 2023
|
Thanks @jbrockmendel |
3 tasks
Closed
3 tasks
galipremsagar
added a commit
to rapidsai/cudf
that referenced
this pull request
Oct 12, 2023
This PR deprecates `is_datetime64tz_dtype` and `is_interval_dtype` to have parity with pandas-2.x: pandas-dev/pandas#52607, alternatively this PR internalizes these utilities. This PR: ``` = 1584 failed, 98570 passed, 2069 skipped, 776 xfailed, 312 xpassed, 20 errors in 737.24s (0:12:17) = ``` On `pandas_2.0_feature_branch`: ``` = 23835 failed, 5698 passed, 1613 skipped, 288 xfailed, 423 errors in 1976.84s (0:32:56) = ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.