-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Remove versionadded/changed for 1.1.0 #52905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -335,7 +335,6 @@ compression : {``'infer'``, ``'gzip'``, ``'bz2'``, ``'zip'``, ``'xz'``, ``'zstd' | |
create a reproducible gzip archive: | ||
``compression={'method': 'gzip', 'compresslevel': 1, 'mtime': 1}``. | ||
|
||
.. versionchanged:: 1.1.0 dict option extended to support ``gzip`` and ``bz2``. | ||
.. versionchanged:: 1.2.0 Previous versions forwarded dict entries for 'gzip' to ``gzip.open``. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is the idea to do 1.2.0 separately? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was pushback when I suggested removing everything up to 1.4 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm good with going up to, but not including, 1.3. That seemed to be the consensus in #51071 to me (note @lithomas1 first said up to 1.1, then up to 1.3.5 after). Looking at the last 30 days of downloads, 1.3.5 is at 18% whereas 1.2.5 is at 5%. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will do as follow up. |
||
thousands : str, default ``None`` | ||
Thousands separator. | ||
|
@@ -3890,8 +3889,6 @@ The :func:`~pandas.read_excel` method can read OpenDocument spreadsheets | |
# Returns a DataFrame | ||
pd.read_excel("path_to_file.ods", engine="odf") | ||
|
||
.. versionadded:: 1.1.0 | ||
|
||
Similarly, the :func:`~pandas.to_excel` method can write OpenDocument spreadsheets | ||
|
||
.. code-block:: python | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to keep this as an example of how to add this sphinx syntax. Might be good to just update the version (and the sentence below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, like
2.1.0
(and update the "This will put the text New in version 1.1.0" text below)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, should have read in more detail