Skip to content

ENH/DEPR: infer date objects to date[pyarrow] dtype #53165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 27 commits into from
Closed

ENH/DEPR: infer date objects to date[pyarrow] dtype #53165

wants to merge 27 commits into from

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented May 10, 2023 •
edited
Loading

Sits on top of #53025.

A few issues this brings up that we should decide on before merging

  • constructing a Categorical from an object-dtype Index does type inference on the categories; is that always wanted?
  • infer_dtype will see a mixed sequence of dates-and-datetimes and return "date"; sure we want that? AFAICT the main place it is relevant is in Index._maybe_promote
  • Desired behavior of DatetimeIndex.get_indexer(index_of_dates)? ATM the index_of_dates would have object dtype and get cast to DTI in Index._maybe_promote.
  • date32 vs date64?
  • extend the relevant tests with the future behavior
  • handle construction from scalar

@mroeschke mroeschke added datetime.date stdlib datetime.date support Arrow pyarrow functionality labels May 15, 2023
@jbrockmendel jbrockmendel force-pushed the poc-future-2 branch 4 times, most recently from 3824c90 to dcdc48a Compare May 22, 2023 19:20
@jbrockmendel jbrockmendel mentioned this pull request May 23, 2023
Closed
5 tasks
@jbrockmendel jbrockmendel force-pushed the poc-future-2 branch 3 times, most recently from 18e7eca to 37f0136 Compare June 5, 2023 19:53
@jbrockmendel jbrockmendel requested a review from WillAyd as a code owner June 5, 2023 19:53
@jbrockmendel
Copy link
Member Author

mothballing until after (at least) #53025

@jbrockmendel jbrockmendel added the Mothballed Temporarily-closed PR the author plans to return to label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd Awaiting requested review from WillAyd

Assignees
No one assigned
Labels
Arrow pyarrow functionality datetime.date stdlib datetime.date support Mothballed Temporarily-closed PR the author plans to return to
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke