ENH: allow EADtype to specify _supports_2d #54832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
ExtensionArray
mroeschke
reviewed
Aug 30, 2023
| # skip tests that are defined in Dim2CompatTests | ||
| test_func = node._obj | ||
| if test_func.__qualname__.startswith("Dim2CompatTests"): | ||
| # TODO: is there a less hacky way of checking this? |
There was a problem hiding this comment.
Could the tests in Dim2CompatTests just be skipped if data.dtype._supports_2d?
There was a problem hiding this comment.
this is skipping if not data.dtype.supports_2d. The acrobatics here are for test classes that subclass ExtensionTests, since we want this fixture to only apply to tests defined in Dim2CompatTests, not all tests in ExtensionTests
mroeschke
approved these changes
Sep 1, 2023
|
Thanks @jbrockmendel |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.The can_fast_transpose bit isn't used but is future-proofing for a time when we have e.g. pyarrow tables backing a 2D EA where transposing isn't cheap. If asked, I'll revert that bit until it is necessary.