Updated future warning msg in transform() for Series.groupby #55082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsm-23
changed the title
|
Simple change to make the warning message a lot more clear, thank you! |
|
@rhshadrach can you please review this? |
mroeschke
reviewed
Sep 11, 2023
pandas/core/apply.py
Outdated
| @@ -1832,12 +1832,12 @@ def warn_alias_replacement( | |||
| full_alias = alias | |||
| else: | |||
| full_alias = f"{type(obj).__name__}.{alias}" | |||
| alias = f"'{alias}'" | |||
| alias = f'`"{alias}"`' | |||
There was a problem hiding this comment.
Might be good to remove the `s as they might not always render like markdown for example
mroeschke
approved these changes
Sep 11, 2023
|
Thanks @rsm-23 |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 11, 2023
…() for Series.groupby
mroeschke
pushed a commit
that referenced
this pull request
Sep 11, 2023
…nsform() for Series.groupby) (#55097) Backport PR #55082: Updated future warning msg in transform() for Series.groupby Co-authored-by: Rajat Subhra Mukherjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.