Skip to content

CI/DOC: Enforce SA05 in CI #57352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

jordan-d-murphy
Copy link
Contributor

@jordan-d-murphy jordan-d-murphy commented Feb 11, 2024

Enforce SA05 in CI so that it can be fixed and enforced in chunks like other docstring errors.

The added functions come from the result of running scripts/validate_docstrings.py --format=actions --errors=SA05

Part of our ongoing work to continue enforcing numpydoc validations: https://numpydoc.readthedocs.io/en/latest/validation.html#built-in-validation-checks

@jordan-d-murphy
Copy link
Contributor Author

pre-commit.ci autofix

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Feb 12, 2024
@mroeschke mroeschke added this to the 3.0 milestone Feb 12, 2024
@mroeschke mroeschke merged commit 2393a13 into pandas-dev:main Feb 12, 2024
@mroeschke
Copy link
Member

Thanks @jordan-d-murphy

@jordan-d-murphy jordan-d-murphy deleted the enforce_SA05 branch February 12, 2024 18:34
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* Enforce SA05 in CI

* sorted SA05 functions in code_checks.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants