BUG: infer_freq results in None for hourly freq with timezone #7371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added a commit
that referenced
this pull request
Jun 6, 2014
BUG: infer_freq results in None for hourly freq with timezone
|
thanks |
|
hmm, this broke in 3.4: https://travis-ci.org/pydata/pandas/jobs/26939770 |
|
this is broken in 2.7 as well, just bisected it |
|
@sinhrks going to revert this |
|
@cpcloud also putting 3.4 on the main build (and 3.2 on experimental, just to have it run) |
|
cool, just reverted d91d145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found fix #7318 was incorrect. It works for lower frequencies than dates, but not for higher freq than hours.
I couldn't detect as test cases are also incorrect...
This should work for all the freqs with timezones.
NOTE: I couldn't use normal
tslib.tz_convertwhich returns incorrect results maybe caused by DST. Applyingtslib.tz_convert_singlecan work though.