WIP/ENH: allow read_excel to accept URLs (GH6809) #7531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good.... @jorisvandenbossche @cpcloud comments? |
|
(Removed vestigial |
|
looks good |
jreback
added a commit
that referenced
this pull request
Jun 23, 2014
WIP/ENH: allow read_excel to accept URLs (GH6809)
|
thanks @dsm054 glad to have you back on the wagon! |
|
https://travis-ci.org/pydata/pandas/jobs/30344018 any idea why the network decorator didn't catch this? (maybe need to add this exact error message to the error list)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6809
This borrows the mechanisms already used in read_csv to enable reading of Excel objects via URLs.
Not sure what tests are appropriate, and I'm not certain what the various decorators do, so I tried to mirror the read_csv tests as best I could.