BUG: Allow __name__less callables as groupby hows (GH7929) #7974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return _get_callable_name(obj.func) | ||
| # fallback to class name | ||
| if hasattr(obj, '__call__'): | ||
| return obj.__class__.__name__ |
There was a problem hiding this comment.
if this fails it returns None? (not sure what would hit that, but maybe make explicit)?
There was a problem hiding this comment.
Yeah, it returns None, not the empty string (assert getname(1) is None), if it can't figure out what do to. You'd have to work pretty hard to have something callable which didn't have __call__.. I can add a comment/return None if you'd like, though.
There was a problem hiding this comment.
yep an explicty None return (and/or comment) is good. lmk after you push and green.
|
@dsm054 minor comment, otherwise looks good |
|
Explicit |
jreback
added a commit
that referenced
this pull request
Aug 10, 2014
BUG: Allow __name__less callables as groupby hows (GH7929)
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
functools.partialobjects (and similar callables without__name__attributes) to be used asgroupbyfunctions, which also adds support along the tree (e.g.resample, which is specifically tested.)Closes #7929.
This does not address the potential enhancements allowing automatic naming of duplicate-named functions (relatively minor) and the use of a Series to specify names (more useful).