User facing AssertionError in empty groupby GH5289 #8987
Conversation
|
would be nice to have a test that hits this also need to remove the .deb file that seemed to be added to the repo |
|
Ok doing that - might need abit of help with the tests - since I'm not an expert on these yet. |
| def test_convert_grouper(axis, grouper): | ||
| def f(): | ||
| len(grouper) != len(axis) | ||
| self.assertRaisesRegexp(ValueError, 'Grouper and axis must be same length', f) |
There was a problem hiding this comment.
you need to create a frame and a grouper that actually hits this test. Put a debug statement where the AssertionError is now and run the test suite and see what conditions you need to have it hit their (and if not, then maybe the code is not doing anything)
There was a problem hiding this comment.
Ok I'll get around to this soon. Create frame and grouper and then the test - what sort of debug statement did you have in mind?
There was a problem hiding this comment.
I just put in a import pdb; pdb.set_trace() right where I want to stop then run the test_groupby.py and see what happens. (this is just to figure things out of course)
jreback
changed the title
jreback
added
Frequency
|
@springcoil can you revisit |
|
Ok I'll have a look and see what is going wrong. |
|
closing pls reopen if/when updated |
closes #5289
Is this all we need to do?
Or am I missing something?