BUG: where gives incorrect results when upcasting (GH 9731) #9743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if `value` is an integer or integer array, convert to `dtype` | ||
| """ | ||
| if dtype in _DATELIKE_DTYPES: | ||
| if np.isscalar(value): |
….where test for Windows
jreback
added
the
Indexing
jreback
added a commit
that referenced
this pull request
Apr 2, 2015
BUG: where gives incorrect results when upcasting (GH 9731)
|
@evanpw thanks! this was subtle! |
|
I assume you changed to use if so, can you do a pr with those? |
|
The tests that were failing after I changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9731
The main issue is when the destination and source arrays have different lengths,
np.putmaskdoesn't behave likearr[mask] = values:"Sets
a.flat[n] = values[n]for each n wheremask.flat[n]==True"We have to use
np.placeinstead. A secondary issue is thatnp.placedoesn't automatically convert an integer to adatetime64likenp.putmaskdoes (I created a numpy issue for this), so we need an additional check for that case. The rest of the commit is just cleaning up_maybe_upcast_putmask, which had some parameters that were never used, and a confusing docstring.