Skip to content

Conversation

@aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Nov 26, 2021

Closes #635

implement for:

  • HindcastEnsemble.verify()
  • PerfectModelEnsemble.verify()
  • bootstrap?

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #690 (68d1b05) into main (c113bf1) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
+ Coverage   93.78%   93.85%   +0.07%     
==========================================
  Files          58       58              
  Lines        6126     6205      +79     
==========================================
+ Hits         5745     5824      +79     
  Misses        381      381              
Impacted Files Coverage Δ
climpred/classes.py 95.00% <100.00%> (+0.34%) ⬆️
climpred/metrics.py 91.76% <100.00%> (+0.14%) ⬆️
climpred/tests/test_HindcastEnsemble_class.py 100.00% <100.00%> (ø)
climpred/tests/test_PerfectModelEnsemble_class.py 98.96% <100.00%> (+0.04%) ⬆️
climpred/tests/test_metrics.py 86.13% <100.00%> (+2.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f6ef2...68d1b05. Read the comment docs.

@aaronspring aaronspring marked this pull request as ready for review November 26, 2021 23:24
@aaronspring aaronspring merged commit df84504 into main Nov 26, 2021
@aaronspring aaronspring deleted the verify_groupby branch November 26, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PredictionEnsemble.groupby('init.month/season/week/dayofyear').verify()

2 participants