Misc Fixes #363
Merged
Misc Fixes #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our comment detection was a bit buggy because we did not use the extend keyword. This meant that if the comment was contained within a region or a match of sorts, it would get pre-maturely ended by a containing group. Using the extend keyword means that it will override any containing parent matcher and still display a comment, which is how JS actually interprets the code.
This should vastly improve how destructuring is handled in function declarations. It is still far from perfect, and a major problem right now is how to support multiple lines in lambda functions
Since we had to remove the contained argument for jsFuncBlock, it caused false positives for object definitions at the top level of a file. I've made jsBlock a higher priorty than jsFuncBlock by placing jsBlock AFTER jsFuncBlock.
This is wonderful! Thanks for the explanation. |
|
Any qualms with merging this in? Otherwise I'll go ahead and do just that. |
|
No qualms. I won't claim to understand all the changes, though. ;) |
|
Haha, no worries, it's weird to even explain some of them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a few fixes we should get into
developbefore mergingdevelopintomaster.Fixed Comment Regions
Function Argument Declaration Destructuring Improvements
Fixed
jsBlockvsjsFuncBlockpriority in top level codejsFuncBlock. This bug was introduced from my earlier updates to arrow functions. The simple fix for this was to makejsBlockhigher priority.jsFuncBlockcontinues to work normally in other contexts because specifiers likenextgroup=take priority.Note
We still have a major issue with arrow function declarations - allowing the argument parenthesis to span multiple lines. This is actually quite a challenging regex problem, and I don't think I will be able to come up with a fix in a reasonable amount of time and think we should ship the current
developbranch with these fixes asap since there's a lot of great stuff in there.