Skip to content

simplifies the parentheses handling #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2016
Merged

Conversation

bounceme
Copy link
Collaborator

@bounceme bounceme commented Apr 16, 2016

also a possible fix for the last example in #329 and #315.
this still needs some work

@bounceme
Copy link
Collaborator Author

This really improves a lot from my testing.
try with this code:

var magicWords = [ 'abracadabra'
  , 'gesundheit'
  , 'ventrilo'
]
  , spells = { 'fireball' : function () { setOnFire() }
  , 'water' : function () { putOut() }
  }
  , a = 1
  , b = 'abc'
  , etc
  , somethingElse
someFunc(param1, param2,

         param3, param4)
randomFunctionCall('blaaaaaaaaaaaaaa ' +
                   'and some more bla',




                   'f')

console.log("value");
randomFunctionCall = {'blaaaaaaaaaaaaaa ':'t'

  ,'and some more bla':3}


let s:var_stmt = '^\s*(const\|let\|var)'
let s:var_stmt = '^\s*\%(const\|let\|var\)'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this broken before, due to the ( and ) not being escaped?

also a possible fix for the last example in pangloss#329 and pangloss#315
@amadeus
Copy link
Collaborator

amadeus commented Apr 19, 2016

@bounceme thanks for squashing/cleaning this up. Looks good to me!

@amadeus amadeus merged commit 989deba into pangloss:develop Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants