Better handling of multiline ternary indents. #329 #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm good with getting this in, anyone object? |
|
Sorry, my new request already fixes this |
|
So you're saying we should merge in #383 and not this one? |
|
Yea, it can be merged soon, i'll let you know when it's done.There are a few bugs still |
|
Closing due to #385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #329, here is a PR with my change.
One thing I noticed when testing again, is that the indenting does not working correctly while typing out the multi-line ternary statement, but on re-identing the block, it does. However, this behavior is the same without my changes as well.
I read through the code again and I don't see any obvious reason why it would behave this way. If someone more familiar with the code can point me in the right direction, I'm happy to investigate further.