-
Notifications
You must be signed in to change notification settings - Fork 352
block statement #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
block statement #596
Conversation
shouldn't be too difficult
So this works fine, it's just really slow right now and i have no idea why. also this is what this pr changes:
|
so there is a slight decrease in performance with this pr however this uses the same algorithm from https://github.com/sweet-js/sweet.js/wiki/design#give-lookbehind-to-the-reader which the acorn parser also uses. it actually is basically the same as what i had originally but with support for labeled block statements and plain block statements. My results with https://github.com/sanctuary-js/sanctuary-def/blob/master/index.js
|
`8.679 seconds` how? I don't see why direction should matter if the patterns explicitly match against the cursor position. The `W` flag also helped
if this improved performance
will probably merge this tomorrow evening after some more testing |
shouldn't be too difficult