Conversation
shouldn't be too difficult
Collaborator
Author
|
So this works fine, it's just really slow right now and i have no idea why. also this is what this pr changes: |
Collaborator
Author
|
so there is a slight decrease in performance with this pr however this uses the same algorithm from https://github.com/sweet-js/sweet.js/wiki/design#give-lookbehind-to-the-reader which the acorn parser also uses. it actually is basically the same as what i had originally but with support for labeled block statements and plain block statements. My results with https://github.com/sanctuary-js/sanctuary-def/blob/master/index.js
|
`8.679 seconds` how? I don't see why direction should matter if the patterns explicitly match against the cursor position. The `W` flag also helped
if this improved performance
Collaborator
Author
|
will probably merge this tomorrow evening after some more testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldn't be too difficult