`EthBundleApiClient` trait clashes with `MevApiClient`

[optimiz-r]

It's a common use-case to want to send a private transaction in conjunction with a bundle, similar to the backrun example in the TS reference implementation.
However, importing both traits will lead to compiler error: they have methods having the same name. Differentiating them, can be verbose see example below.

Proposal 1: Split the API client

One way to address this is by breaking up the EthBundleApiClient into two separate clients:

• EthTxApiClient: this client would exclusively handle individual transactions. It would encompass methods such as:

  • send_private_transaction
  • send_raw_private_transaction
  • cancel_private_transaction

• EthBundleApiClient: this client would retain methods specifically designed for bundle operations, including:

  • send_bundle
  • sim_bundle
  • cancel_bundle

Proposal 2: Prefix the 'eth' methods

An alternative solution would be to prefix the eth methods, for instance, renaming send_bundle to eth_send_bundle. However, this approach might introduce a new expectation for the mev_* methods to follow a similar naming convention, like mev_send_bundle.
This inconsistency can be confusing for users. Therefore, Proposal 1 might be more intuitive.

[mattsse]

Importing both leads to compiler error and using it without compiler error is verbose

do you mean when calling the function?

I recommend using the fully qualified syntax in this case

but I'd be okay with prefixing them

wdyt @FrankieIsLost ?

[optimiz-r]

OK, sorry for live editing, I mistakenly submitted while still drafting. I should probably get into the habit of entering the title last.

Anyhow, using the fully qualified syntax is what I'm currently doing in the recently added example:

let tx_to_backrun_hash =
      mev_share_rpc_api::EthBundleApiClient::send_private_transaction(&client, private_tx)
           .await?;

this could be:

let tx_to_backrun_hash = client.send_private_transaction(&private_tx).await?;

Seems worthwhile? Will draft PR.

[mattsse]

sgtm!