Skip to content

feat: added store PeerKind in known-peers file logic #15770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: added store PeerKind in known-peers file logic #15770

wants to merge 8 commits into from

Conversation

Soubhik-10
Copy link
Contributor

closes #15765

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Apr 16, 2025
@Soubhik-10
Copy link
Contributor Author

@mattsse is this ok??

mattsse
mattsse requested changes Apr 17, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty,

some additional nits

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Apr 17, 2025
@Soubhik-10
Copy link
Contributor Author

@mattsse please check :)

@Soubhik-10 Soubhik-10 requested a review from mattsse April 18, 2025 12:52
mattsse
mattsse reviewed Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty,

this is complete, just need to do something else before we can merge

@Soubhik-10
Copy link
Contributor Author

ty,

this is complete, just need to do something else before we can merge

lmk if i need to do anything :)

louisbrown0212
louisbrown0212 reviewed May 1, 2025
View reviewed changes
@Soubhik-10 Soubhik-10 requested a review from mattsse May 29, 2025 05:38
@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jun 20, 2025
@github-actions github-actions bot closed this Jun 27, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Jun 27, 2025
@Soubhik-10
Copy link
Contributor Author

ty,

this is complete, just need to do something else before we can merge

lmk if i need to do anything :)

😶

@mattsse mattsse reopened this Jun 29, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Reth Tracker Jun 29, 2025
@mattsse mattsse added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity A-networking Related to networking in general and removed S-stale This issue/PR is stale and will close with no further activity labels Jun 29, 2025
@mattsse mattsse self-assigned this Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisbrown0212 louisbrown0212 louisbrown0212 left review comments

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@mattsse mattsse

Labels
A-networking Related to networking in general M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Reth Tracker
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store PeerKind in known-peers file
3 participants
@Soubhik-10 @mattsse @louisbrown0212