Upgrade dependency on Mbed Crypto to v2.0.0 #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing to note is that because of bindgen being unable to generate bindings for Also, we'll need, at some point, to implement what Mbed Crypto calls |
This commit bumps the import version for the Mbed Crypto dependency to 2.0.0. It includes updates to make the code compatible and tests passing again. Signed-off-by: Ionut Mihalcea <[email protected]>
hug-dev
approved these changes
Oct 29, 2019
| @@ -34,7 +34,7 @@ toml = "0.4.2" | |||
| serde = { version = "1.0", features = ["derive"] } | |||
|
|
|||
| [package.metadata.config] | |||
| mbed-crypto-version = "mbedcrypto-1.1.0" | |||
| mbed-crypto-version = "mbedcrypto-2.0.0" | |||
| && key_id != 0 | ||
| && key_id < constants::PSA_MAX_PERSISTENT_KEY_IDENTIFIER | ||
| || key_id == 0 | ||
| || key_id > constants::PSA_MAX_PERSISTENT_KEY_IDENTIFIER |
There was a problem hiding this comment.
I'm still horrified I made that mistake in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping dependency version of Mbed Crypto to 2.0.0. Also making all changes required to keep the service functional. This included a change in the client library, bumping that to
0.1.5.This resolves #38