Ensure the safety of unsafe blocks #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks all unsafe uses and comment why it is safe to use unsafe in the specific context. Refactors the utils module to make it easier to prove safety. Signed-off-by: Hugues de Valon <[email protected]>
It should be easier to see why a test was wrong reading the logs. The verbose output of the cargo commands is only needed when things do not compile. To not enable logging on stress tests, the environment variables are used. Signed-off-by: Hugues de Valon <[email protected]>
This was referenced Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks all unsafe uses and comment why it is safe to use unsafe in the
specific context.
Refactors the utils module to make it easier to prove safety.
Signed-off-by: Hugues de Valon [email protected]