Fix wrong mapping of AttributeType::CertificateType #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Yep, looks like a simple "typo" especially that the reverse op is here: https://github.com/parallaxsecond/rust-cryptoki/pull/116/files#diff-8eed47b951056624bcbe744076eac12fab93c4fe6c655c937351243a0db816daR278
Thanks! 👍
|
🎉 #117 has been merged, this can be rebased on top of |
Signed-off-by: Boris-Chengbiao Zhou <[email protected]>
cfrantz
added a commit
to cfrantz/opentitan
that referenced
this pull request
May 19, 2023
Add parallaxsecond/rust-cryptoki#116 to rust-cryptoki, allowing cryptoki to understand certificate objects on the NitroKey. Signed-off-by: Chris Frantz <[email protected]>
cfrantz
added a commit
to cfrantz/opentitan
that referenced
this pull request
May 22, 2023
Add parallaxsecond/rust-cryptoki#116 to rust-cryptoki, allowing cryptoki to understand certificate objects on the NitroKey. Signed-off-by: Chris Frantz <[email protected]>
cfrantz
added a commit
to lowRISC/opentitan
that referenced
this pull request
May 22, 2023
Add parallaxsecond/rust-cryptoki#116 to rust-cryptoki, allowing cryptoki to understand certificate objects on the NitroKey. Signed-off-by: Chris Frantz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.