Skip to content

Implement update attributes for objects #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

baloo
Copy link
Contributor

@baloo baloo commented Jan 13, 2023

No description provided.

@wiktor-k
Copy link
Collaborator

Ugh, the build failed due to #114 not being merged :-/

@baloo
Copy link
Contributor Author

baloo commented Jan 13, 2023

I'll rebase when that merges :)

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Thanks!

@wiktor-k
Copy link
Collaborator

I've replaced #114 with #122 that has been merged so you're good to go for rebasing this PR :shipit:

@baloo baloo force-pushed the baloo/update-attributes branch from f66e7c1 to 5b28163 Compare January 24, 2023 17:26
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks!

@wiktor-k wiktor-k enabled auto-merge January 24, 2023 18:37
auto-merge was automatically disabled January 24, 2023 18:58

Head branch was pushed to by a user without write access

@baloo baloo force-pushed the baloo/update-attributes branch from 5b28163 to 15a2ef0 Compare January 24, 2023 18:58
@wiktor-k wiktor-k enabled auto-merge January 24, 2023 19:56
auto-merge was automatically disabled January 24, 2023 21:44

Head branch was pushed to by a user without write access

@baloo baloo force-pushed the baloo/update-attributes branch from c8b9b25 to 117199e Compare January 24, 2023 21:45
@wiktor-k
Copy link
Collaborator

wiktor-k commented Jan 25, 2023

@baloo Sorry for the annoyance but could I bother you with squashing these two commits? 🙏 Maybe it's minor but it's good for git bisect if each commit works and passes the CI.

After that I'll make sure to merge it ASAP :)

Edit: the build error is fake, just ignore it :)

@baloo baloo force-pushed the baloo/update-attributes branch from 117199e to e840f46 Compare January 25, 2023 15:25
@wiktor-k wiktor-k enabled auto-merge January 25, 2023 20:12
@wiktor-k wiktor-k merged commit 5c35c82 into parallaxsecond:main Jan 25, 2023
@wiktor-k
Copy link
Collaborator

Thanks for everything! 👋

@baloo baloo deleted the baloo/update-attributes branch January 25, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants