Added missing marks #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two missing mark types
Added missing Super and Sub-script marks
Created additional tests for the Super- and Sub-script marks
|
Not quite sure how to set up the test for Asset though, since it can be any type of file. Furthermore I haven't yet had time to figure out how it resolves the asset information from the document, it seems all it provides is the asset ID. |
tolgap
requested changes
Mar 1, 2023
There was a problem hiding this comment.
@KeyboardRage The MARKS.SUPERSCRIPT and MARKS.SUBSCRIPT changes are great! Thank you for taking the time.
Could you please remove the addition of BLOCKS.EMBEDDED_ASSET from this PR, and perhaps open another PR for it? We can then discuss the implementation of this block separately 🙂.
tolgap
approved these changes
Mar 1, 2023
|
@KeyboardRage released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates handling of super- and sub-script markings. If sup/sub are used in the Rich Editor in Contentful, it'll crash the entire render 😕