Add TODOs for scripture reference formatting enhancements #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix export - improve tsdoc for collapseMiddleWords - separate formatScrRef from function that handles optional parameters - use options object for formatScrRef and formatScrRefRange - added test case
Add TODO comments for handling specific scripture formatting cases.
Sebastian-ubs
requested review from
irahopkinson,
jolierabideau,
lyonsil,
rolfheij-sil and
tjcouch-sil
as code owners
tjcouch-sil
reviewed
Dec 22, 2025
Member
tjcouch-sil
left a comment
tjcouch-sil
left a comment
There was a problem hiding this comment.
I can't really tell what's going on in this PR; if it is still relevant, would you mind rebasing from origin/main please? I think right now it is showing all the changes from your old branch as well, so it looks like everything is new.
@tjcouch-sil reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: 4 of 10 files reviewed, all discussions resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TODO comments for handling specific scripture formatting cases.
follow up for https://reviewable.io/reviews/paranext/paranext-core/1952#-OggwcxbAkzirdYGpSMg from
This change is