Skip to content

Drop Node 12 in tests and add Node 16 #7935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devongovett merged 2 commits into from
Apr 26, 2022
Merged

Drop Node 12 in tests and add Node 16 #7935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b9a997
Drop Node 12 in tests and add Node 16
mischnic Apr 11, 2022
06f41e0
Fix vm usage for Node 16
mischnic Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
name: Unit tests (${{matrix.os}}, Node ${{matrix.node}})
strategy:
matrix:
node: [12, 14]
node: [14, 16]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{matrix.os}}
steps:
Expand All @@ -64,7 +64,7 @@ jobs:
name: Integration tests (${{matrix.os}}, Node ${{matrix.node}})
strategy:
matrix:
node: [12, 14]
node: [14, 16]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{matrix.os}}
steps:
Expand Down
3 changes: 2 additions & 1 deletion packages/core/test-utils/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,8 @@ export async function runESM(
identifier: `${normalizeSeparators(
path.relative(baseDir, filename),
)}?id=${id}`,
importModuleDynamically: entry,
importModuleDynamically: (specifier, referrer) =>
entry(specifier, referrer),
Comment on lines +991 to +992
Copy link
Member Author

@mischnic mischnic Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vm module used in the integration tests requires a change for Node 16. The only item regarding vm in the changelog

A prime example of how adding a paramater to a callback is a breaking change...

context,
initializeImportMeta(meta) {
meta.url = `http://localhost/${path.basename(filename)}`;
Expand Down