chore: update build to support NodeNext#455
Closed
ryanleecode wants to merge 1 commit into
Closed
Conversation
ryanleecode
force-pushed
the
chore/update-nodenext
branch
from
599148d to
43fb57f
Compare
ryanleecode
force-pushed
the
chore/update-nodenext
branch
from
43fb57f to
d3b4be3
Compare
ryanleecode
changed the title
Contributor
Author
ryanleecode
commented
Oct 23, 2024
| /* eslint-disable @typescript-eslint/ban-ts-comment */ | ||
| // https://github.com/isaacs/tshy?tab=readme-ov-file#commonjs-dialect-polyfills | ||
| // @ts-ignore suppress "Import assertions are not allowed on statements that compile to CommonJS 'require' calls." | ||
| import registry from '@substrate/asset-transfer-api-registry/docs/registry.json' assert { type: 'json' }; |
Contributor
Author
There was a problem hiding this comment.
needs another release on https://github.com/paritytech/asset-transfer-api-registry to see if the change to esm style exports will fix this
Contributor
Author
|
I'm not sure what changed but it looks like Yarn isn't installing the transitive dependencies of @substrate/dev |
Member
I think this has always been an issue. It's why the scripts access the node_modules directly. Similar issue I filed awhile ago: yarnpkg/berry#2784 |
Contributor
|
Given that this PR is stale, I am closing it in favor of #561. If I was premature, just let me know and we can reopen this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.