fix: add xcmVersion arg to DryRunCall#553
Merged
Merged
Conversation
filvecchiato
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #547
Description
The Kusama runtime was upgraded to version
1005000and theDryRunCallnow takes also thexcmVersionas an argument. Polkadot is still in version1004001so it still takes 2 arguments. The change in this PR makesasset-transfer-apiwork for both upgraded and non-upgraded runtimes.Testing
You can test the change by running the below demo for
Kusamaby adding the xcmVersion in the arguments:and this demo for
Polkadotwithout giving the xcmVersion as an argumentPlease link the above demos to the
asset-transfer-apipackage that you have cloned locally and checked out in the current branch (which contains the fix).Todos