chainHead/follow: Provide multiple finalized block hashes by the Initialized event#136
Merged
Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
tomaka
reviewed
Feb 14, 2024
tomaka
reviewed
Feb 14, 2024
Contributor
|
Also a |
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
tomaka
approved these changes
Feb 14, 2024
jsdw
reviewed
Feb 15, 2024
jsdw
previously approved these changes
Feb 15, 2024
jsdw
left a comment
jsdw
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall and love the change :)
Just a nit about the use of currentFinalizedBlock
Co-authored-by: James Wilson <james@jsdw.me>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
reviewed
Feb 15, 2024
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
reviewed
Feb 21, 2024
jsdw
reviewed
Feb 21, 2024
jsdw
previously approved these changes
Feb 21, 2024
jsdw
left a comment
jsdw
left a comment
Contributor
There was a problem hiding this comment.
Minor suggestions but looks good to me!
Co-authored-by: James Wilson <james@jsdw.me>
jsdw
previously approved these changes
Feb 21, 2024
jsdw
left a comment
jsdw
left a comment
Contributor
There was a problem hiding this comment.
One other minor thing left but LGTM
Co-authored-by: James Wilson <james@jsdw.me>
jsdw
approved these changes
Feb 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the
Initializedevent of thechainHead_followsubscription.Now, the event provides multiple finalized block hashes. This information allows clients that are disconnected, and that want to reconnect, to not lose information about the state of the chain.
At the moment, the spec encourages servers to provide at least 1 minute of finalized blocks (~10 blocks). The users are responsible for unpinning these blocks at a later time.
Closes: #81
cc @paritytech/subxt-team