Skip to content

parity-util-mem: use ios compilation conditions same as macos. #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2021
Merged

parity-util-mem: use ios compilation conditions same as macos. #522

merged 2 commits into from
Feb 8, 2021

Conversation

artemii235
Copy link
Contributor

Fixes #521

ordian
ordian approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I don't know which allocator iOS uses by default and whether it's possible to use jemalloc there.

It's fine to merge this if you tested it locally, however it would be hard for us to support iOS w/o proper CI setup for it.

@ordian ordian requested a review from cheme February 8, 2021 10:21
@ordian
Copy link
Member

ordian commented Feb 8, 2021

(asking @cheme for a review because they implemented #93)

@artemii235
Copy link
Contributor Author

I guess I have to fix the formatting, I will push it asap.

@artemii235 artemii235 mentioned this pull request Feb 8, 2021
Closed
cheme
cheme approved these changes Feb 8, 2021
View reviewed changes
Copy link
Collaborator

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the cfg default to estimate heap size when we do not use jemalloc (so for mac and ios only option is jemalloc now, not sure if other allocator could make sense for those targets).

@niklasad1 niklasad1 merged commit 3ad905d into paritytech:master Feb 8, 2021
ordian pushed a commit that referenced this pull request Feb 16, 2021
Merge branch 'master' into dependabot/cargo/scale-info-0.6
9d9c7b6 
* master:
  build(deps): update sysinfo requirement from 0.15.3 to 0.16.3 (#526)
  CI: add a workaround for build issue (#527)
  parity-util-mem: use ios compilation conditions same as macos. (#522)
@cheme cheme mentioned this pull request May 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheme cheme cheme approved these changes

@ordian ordian ordian approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mem-util] reaching unreachable!(...) on iOS.
4 participants
@artemii235 @ordian @cheme @niklasad1