Remove heapsize #94
Remove heapsize #94
Conversation
(it is the less impacting approach).
`get_malloc_size_src.sh`. Add missing impls.rs with ethereum types related implementation.
Fix a no_std deps issue.
Documentation enhancements. Explicits imports.
Co-Authored-By: cheme <[email protected]>
switching back to jemalloc.
There was a problem hiding this comment.
Could you update https://github.com/paritytech/parity-common/pull/94/files#diff-800310df350583bcaff8649efb9b9042L16 and resolve merge conflicts? Looks good otherwise.
|
I did resolve merge conflict, I am generally more in favor with merging #93 in a first step. |
|
I put this pr on ice (behind #93) that fix the mac behavior. |
|
@cheme, could you resolve conflicts? |
|
removing |
Co-Authored-By: Andronik Ordian <[email protected]>
There was a problem hiding this comment.
Looks nice in general but as this is probably going to have a huge impact upstream, we need new versions of all dependent crates.
Personally I'd love some guidance/docs in the crate on the recommended way of updating code upstream that currently use the heapsizeof crate (explicitly or implicitly through features).
| @@ -4,7 +4,6 @@ Collection of memory related utilities. | |||
|
|
|||
| ## Features | |||
|
|
|||
| - volatile-erase : Not set by default, `Memzero` struct will be erasing memory through a simple [`write_volatile`](https://doc.rust-lang.org/std/ptr/fn.write_volatile.html) call. | |||
| - estimate-heapsize : Do not use allocator, but `size_of` or `size_of_val`. | |||
There was a problem hiding this comment.
(commenting here because GH doesn't allow me to comment below)
Need to update the ## Dependency section too now that CoD is removed.
| @@ -4,7 +4,6 @@ Collection of memory related utilities. | |||
|
|
|||
| ## Features | |||
There was a problem hiding this comment.
Can you add a recommended way of using this crate to, for example, replace code that uses heapsizeof today and wishes to stop? :)
| parking_lot = { version = "*", optional = true } | ||
| elastic-array = { version = "0", optional = true } | ||
| ethereum-types = { version = "0", optional = true } | ||
| parking_lot = { version = "0", optional = true } |
There was a problem hiding this comment.
This should work fine, says cargo publish --dry-run
|
Published |
This PR is an alternative to #93 , it skips the deprecation step and directly remove heapsize usage in all parity-common crates.
Like #93 it is a follow up to #89 . It could also be a follow up to #93 if we first deprecate things.
Edit: #93 needs to be merged first because it includes fixes for macos