Skip to content
This repository was archived by the owner on Oct 11, 2023. It is now read-only.

Try to use less fields for the payloads in order to avoid parsing errors #294

Merged
merged 4 commits into from
May 28, 2021

Conversation

joao-paulo-parity
Copy link
Contributor

The bot got stuck in paritytech/polkadot#2990 due to a parsing error from a commit status:

{"severity":"INFO","message":"Ignoring payload parsing error","timestamp":"2021-05-27T14:21:42.756882005Z"}

Apparently the JSON payload is fine, which means the serde deserialization failed on our side for some reason.

JSON
{"id":13248674710,"sha":"d37101e9c48af97596dd334cfe8ee84af4d38a94","name":"paritytech/polkadot","target_url":null,"avatar_url":"https://avatars.githubusercontent.com/in/110390?v=4","context":"cla","description":null,"state":"success","commit":{"sha":"d37101e9c48af97596dd334cfe8ee84af4d38a94","node_id":"MDY6Q29tbWl0MTQ0MTQwMzQyOmQzNzEwMWU5YzQ4YWY5NzU5NmRkMzM0Y2ZlOGVlODRhZjRkMzhhOTQ=","commit":{"author":{"name":"parity-processbot","email":"","date":"2021-05-27T12:55:53Z"},"committer":{"name":"parity-processbot","email":"","date":"2021-05-27T12:55:53Z"},"message":"update Substrate","tree":{"sha":"a160ce86b19dcfbfd23ef6db58ca4f85d8679705","url":"https://api.github.com/repos/paritytech/polkadot/git/trees/a160ce86b19dcfbfd23ef6db58ca4f85d8679705"},"url":"https://api.github.com/repos/paritytech/polkadot/git/commits/d37101e9c48af97596dd334cfe8ee84af4d38a94","comment_count":0,"verification":{"verified":false,"reason":"unsigned","signature":null,"payload":null}},"url":"https://api.github.com/repos/paritytech/polkadot/commits/d37101e9c48af97596dd334cfe8ee84af4d38a94","html_url":"https://github.com/paritytech/polkadot/commit/d37101e9c48af97596dd334cfe8ee84af4d38a94","comments_url":"https://api.github.com/repos/paritytech/polkadot/commits/d37101e9c48af97596dd334cfe8ee84af4d38a94/comments","author":{},"committer":{},"parents":[{"sha":"f46d23ded73938ba661815a9a852cb62769914eb","url":"https://api.github.com/repos/paritytech/polkadot/commits/f46d23ded73938ba661815a9a852cb62769914eb","html_url":"https://github.com/paritytech/polkadot/commit/f46d23ded73938ba661815a9a852cb62769914eb"}]},"branches":[{"name":"kpp-companion-8748","commit":{"sha":"d37101e9c48af97596dd334cfe8ee84af4d38a94","url":"https://api.github.com/repos/paritytech/polkadot/commits/d37101e9c48af97596dd334cfe8ee84af4d38a94"},"protected":false}],"created_at":"2021-05-27T14:21:42+00:00","updated_at":"2021-05-27T14:21:42+00:00","repository":{"id":144140342,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQxNDAzNDI=","name":"polkadot","full_name":"paritytech/polkadot","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/polkadot","description":"Polkadot Node Implementation","fork":false,"url":"https://api.github.com/repos/paritytech/polkadot","forks_url":"https://api.github.com/repos/paritytech/polkadot/forks","keys_url":"https://api.github.com/repos/paritytech/polkadot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/polkadot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/polkadot/teams","hooks_url":"https://api.github.com/repos/paritytech/polkadot/hooks","issue_events_url":"https://api.github.com/repos/paritytech/polkadot/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/polkadot/events","assignees_url":"https://api.github.com/repos/paritytech/polkadot/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/polkadot/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/polkadot/tags","blobs_url":"https://api.github.com/repos/paritytech/polkadot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/polkadot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/polkadot/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/polkadot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/polkadot/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/polkadot/languages","stargazers_url":"https://api.github.com/repos/paritytech/polkadot/stargazers","contributors_url":"https://api.github.com/repos/paritytech/polkadot/contributors","subscribers_url":"https://api.github.com/repos/paritytech/polkadot/subscribers","subscription_url":"https://api.github.com/repos/paritytech/polkadot/subscription","commits_url":"https://api.github.com/repos/paritytech/polkadot/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/polkadot/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/polkadot/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/polkadot/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/polkadot/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/polkadot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/polkadot/merges","archive_url":"https://api.github.com/repos/paritytech/polkadot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/polkadot/downloads","issues_url":"https://api.github.com/repos/paritytech/polkadot/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/polkadot/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/polkadot/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/polkadot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/polkadot/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/polkadot/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/polkadot/deployments","created_at":"2018-08-09T10:57:23Z","updated_at":"2021-05-27T13:02:35Z","pushed_at":"2021-05-27T14:13:55Z","git_url":"git://github.com/paritytech/polkadot.git","ssh_url":"[email protected]:paritytech/polkadot.git","clone_url":"https://github.com/paritytech/polkadot.git","svn_url":"https://github.com/paritytech/polkadot","homepage":"","size":94384,"stargazers_count":3523,"watchers_count":3523,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":720,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":288,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":720,"open_issues":288,"watchers":3523,"default_branch":"master"},"organization":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","url":"https://api.github.com/orgs/paritytech","repos_url":"https://api.github.com/orgs/paritytech/repos","events_url":"https://api.github.com/orgs/paritytech/events","hooks_url":"https://api.github.com/orgs/paritytech/hooks","issues_url":"https://api.github.com/orgs/paritytech/issues","members_url":"https://api.github.com/orgs/paritytech/members{/member}","public_members_url":"https://api.github.com/orgs/paritytech/public_members{/member}","avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=4","description":"Solutions for a trust-free world"},"sender":{"login":"cla-bot-2021[bot]","id":82517672,"node_id":"MDM6Qm90ODI1MTc2NzI=","avatar_url":"https://avatars.githubusercontent.com/in/110390?v=4","gravatar_id":"","url":"https://api.github.com/users/cla-bot-2021%5Bbot%5D","html_url":"https://github.com/apps/cla-bot-2021","followers_url":"https://api.github.com/users/cla-bot-2021%5Bbot%5D/followers","following_url":"https://api.github.com/users/cla-bot-2021%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/cla-bot-2021%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/cla-bot-2021%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cla-bot-2021%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/cla-bot-2021%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/cla-bot-2021%5Bbot%5D/repos","events_url":"https://api.github.com/users/cla-bot-2021%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/cla-bot-2021%5Bbot%5D/received_events","type":"Bot","site_admin":false},"installation":{"id":6784676,"node_id":"MDIzOkludGVncmF0aW9uSW5zdGFsbGF0aW9uNjc4NDY3Ng=="}}

To counteract that, trim down the JSON variants and fields as much as possible in order to not run into parsing errors anymore.

@joao-paulo-parity joao-paulo-parity merged commit 4be550c into master May 28, 2021
@joao-paulo-parity joao-paulo-parity deleted the stuck branch May 28, 2021 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant