[pallet-broker] add extrinsic to forcefully remove the potential renewal by mertwole · Pull Request #10828 · paritytech/polkadot-sdk

mertwole · 2026-01-16T11:07:07Z

Part of #6929

Add an extrinsic allowing to forcefully remove the existing potential renewal from chain without the need to directly manipulate the storage.

mertwole · 2026-01-16T11:09:32Z

/cmd prdoc --audience runtime_user --bump patch

…time_user --bump patch'

mertwole · 2026-01-16T11:12:11Z

bot bench substrate-pallet --pallet=pallet_broker
bot bench cumulus-coretime --pallet=pallet_broker --runtime=coretime-rococo
bot bench cumulus-coretime --pallet=pallet_broker --runtime=coretime-westend

command-bot · 2026-01-16T11:12:18Z

"$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_broker was queued.

Comment bot cancel 1-2b061a0f-29b1-4ab7-99de-e5c7ca19f919 to cancel this command or bot cancel to cancel all commands in this pull request.

github-actions · 2026-01-16T11:12:19Z

We have migrated the command bot to GHA

Please, see the new usage instructions here or here. Soon the old commands will be disabled.

command-bot · 2026-01-16T11:12:22Z

"$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_broker was queued.

Comment bot cancel 2-fa510f13-dd71-4a75-b282-b6150c5a3817 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2026-01-16T11:12:26Z

"$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_broker was queued.

Comment bot cancel 3-57023f36-c579-4a23-b0f9-4b57266becfa to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2026-01-16T11:12:29Z

@mertwole Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_broker has finished. Result:

Error: fatal: unable to access 'https://gitlab.parity.io/parity/mirrors/polkadot-sdk.git/': Could not resolve host: gitlab.parity.io
Error: fatal: unable to access 'https://gitlab.parity.io/parity/mirrors/polkadot-sdk.git/': Could not resolve host: gitlab.parity.io
    at ChildProcess.<anonymous> (/app/build/shell.js:73:39)
    at ChildProcess.emit (node:events:517:28)
    at ChildProcess.emit (node:domain:489:12)
    at maybeClose (node:internal/child_process:1098:16)
    at ChildProcess._handle.onexit (node:internal/child_process:303:5)

command-bot · 2026-01-16T11:12:32Z

@mertwole Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_broker has finished. Result:

Error: fatal: unable to access 'https://gitlab.parity.io/parity/mirrors/polkadot-sdk.git/': Could not resolve host: gitlab.parity.io
Error: fatal: unable to access 'https://gitlab.parity.io/parity/mirrors/polkadot-sdk.git/': Could not resolve host: gitlab.parity.io
    at ChildProcess.<anonymous> (/app/build/shell.js:73:39)
    at ChildProcess.emit (node:events:517:28)
    at ChildProcess.emit (node:domain:489:12)
    at maybeClose (node:internal/child_process:1098:16)
    at ChildProcess._handle.onexit (node:internal/child_process:303:5)

command-bot · 2026-01-16T11:12:35Z

@mertwole Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_broker has finished. Result:

Error: fatal: unable to access 'https://gitlab.parity.io/parity/mirrors/polkadot-sdk.git/': Could not resolve host: gitlab.parity.io
Error: fatal: unable to access 'https://gitlab.parity.io/parity/mirrors/polkadot-sdk.git/': Could not resolve host: gitlab.parity.io
    at ChildProcess.<anonymous> (/app/build/shell.js:73:39)
    at ChildProcess.emit (node:events:517:28)
    at ChildProcess.emit (node:domain:489:12)
    at maybeClose (node:internal/child_process:1098:16)
    at ChildProcess._handle.onexit (node:internal/child_process:303:5)

mertwole · 2026-01-16T11:15:32Z

/cmd bench --pallet pallet_broker

github-actions · 2026-01-16T11:16:17Z

Command "bench --pallet pallet_broker" has started 🚀 See logs here

…t_broker'

github-actions · 2026-01-16T12:53:08Z

Command "bench --pallet pallet_broker" has finished ✅ See logs here

Details

Subweight results:

File	Extrinsic	Old	New	Change [%]
substrate/frame/broker/src/weights.rs	partition	242.93us	673.72us	+177.33
substrate/frame/broker/src/weights.rs	interlace	344.21us	775.37us	+125.26
substrate/frame/broker/src/weights.rs	assign	332.04us	736.98us	+121.96
substrate/frame/broker/src/weights.rs	request_core_count	3.99us	7.05us	+76.76
substrate/frame/broker/src/weights.rs	on_new_timeslice	251.00ns	331.00ns	+31.87
substrate/frame/broker/src/weights.rs	request_revenue_info_at	184.00ns	222.00ns	+20.65
substrate/frame/broker/src/weights.rs	force_reserve	403.07us	446.89us	+10.87
substrate/frame/broker/src/weights.rs	unreserve	139.62us	150.96us	+8.12
substrate/frame/broker/src/weights.rs	drop_history	261.46us	282.19us	+7.92
substrate/frame/broker/src/weights.rs	disable_auto_renew	140.21us	151.19us	+7.83
substrate/frame/broker/src/weights.rs	reserve	140.42us	151.36us	+7.79
substrate/frame/broker/src/weights.rs	set_lease	132.71us	142.26us	+7.20
substrate/frame/broker/src/weights.rs	remove_lease	132.34us	141.46us	+6.89
substrate/frame/broker/src/weights.rs	drop_region	186.28us	197.97us	+6.28
substrate/frame/broker/src/weights.rs	remove_assignment	140.78us	149.60us	+6.26
substrate/frame/broker/src/weights.rs	swap_leases	129.63us	137.54us	+6.10
substrate/frame/broker/src/weights.rs	purchase_credit	171.45us	181.82us	+6.05
substrate/frame/broker/src/weights.rs	transfer	141.40us	149.75us	+5.91
substrate/frame/broker/src/weights.rs	purchase	287.54us	302.63us	+5.25
substrate/frame/broker/src/weights.rs	remove_potential_renewal		143.02us	Added

Command output:

❌ Failed to build coretime-westend
✅ Successful benchmarks of runtimes/pallets:
-- dev: ['pallet_broker']

mertwole · 2026-01-16T14:24:48Z

/cmd bench --pallet pallet_broker
/cmd bench --pallet pallet_broker --runtime coretime-westend

github-actions · 2026-01-16T14:25:37Z

Command "bench --pallet pallet_broker
/cmd bench --pallet pallet_broker --runtime coretime-westend" has started 🚀 See logs here

github-actions · 2026-01-16T14:48:37Z

Command "bench --pallet pallet_broker
/cmd bench --pallet pallet_broker --runtime coretime-westend" has failed ❌! See logs here

mertwole · 2026-01-17T09:54:59Z

/cmd bench --pallet pallet_broker

mertwole · 2026-01-17T09:55:10Z

/cmd bench --pallet pallet_broker --runtime coretime-westend

github-actions · 2026-01-17T09:55:42Z

Command "bench --pallet pallet_broker" has started 🚀 See logs here

github-actions · 2026-01-17T09:55:59Z

Command "bench --pallet pallet_broker --runtime coretime-westend" has started 🚀 See logs here

…t_broker --runtime coretime-westend'

github-actions · 2026-01-17T10:24:15Z

Command "bench --pallet pallet_broker --runtime coretime-westend" has finished ✅ See logs here

Details

Subweight results:

File	Extrinsic	Old	New	Change [%]
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	on_new_timeslice	30.25us	275.17us	+809.81
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	partition	248.38us	672.98us	+170.94
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	interlace	349.67us	774.89us	+121.61
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	assign	336.47us	738.18us	+119.39
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	renew	653.89us	766.19us	+17.17
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	enable_auto_renew	911.33us	1.04ms	+13.66
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	force_reserve	417.83us	457.49us	+9.49
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	drop_region	218.23us	200.43us	-8.16
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	drop_history	328.00us	284.06us	-13.40
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	process_core_schedule	457.11us	371.34us	-18.76
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	drop_contribution	311.26us	243.41us	-21.80
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	purchase_credit	371.54us	290.31us	-21.86
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	request_core_count	196.49us	108.79us	-44.63
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	request_revenue_info_at	191.39us	99.20us	-48.17
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_broker.rs	remove_potential_renewal		139.56us	Added
substrate/frame/broker/src/weights.rs	remove_potential_renewal		0ps	Added

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- coretime-westend: ['pallet_broker']

github-actions · 2026-01-17T10:58:22Z

Command "bench --pallet pallet_broker" has failed ❌! See logs here

Details

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- dev: ['pallet_broker']
-- coretime-westend: ['pallet_broker']

mertwole · 2026-01-17T11:29:59Z

/cmd bench --pallet pallet_broker --runtime dev

ggwpez · 2026-01-21T10:12:46Z

/cmd clean
PS: looks like this does not work like this anymore 🤔

github-actions · 2026-01-21T10:13:34Z

Command "clean" has started 🚀 See logs here

github-actions · 2026-01-21T10:14:57Z

Command "clean" has failed ❌! See logs here

github-actions · 2026-01-21T10:31:36Z

Review required! Latest push from author must always be reviewed

Implement

a8025ac

mertwole requested a review from a team as a code owner January 16, 2026 11:07

mertwole added the T2-pallets This PR/Issue is related to a particular pallet. label Jan 16, 2026

Update from github-actions[bot] running command 'prdoc --audience run…

bae89bd

…time_user --bump patch'

Update from github-actions[bot] running command 'bench --pallet palle…

202851d

…t_broker'

Undo changes in weights

1d2aad9

Add weight placeholder in the coretime-westend runtime

fe9f4f4

Update from github-actions[bot] running command 'bench --pallet palle…

e26f589

…t_broker --runtime coretime-westend'

Fix clippy

167e789

seadanda mentioned this pull request Jan 21, 2026

Expand coretime management functionality for sudo ops #6929

Open

8 tasks

ggwpez reviewed Jan 21, 2026

View reviewed changes

Comment thread substrate/frame/broker/src/lib.rs Outdated

ggwpez reviewed Jan 21, 2026

View reviewed changes

Comment thread substrate/frame/broker/src/tests.rs Outdated

Comment thread substrate/frame/broker/src/tests.rs Outdated

Comment thread substrate/frame/broker/src/tests.rs Outdated

ggwpez reviewed Jan 21, 2026

View reviewed changes

Comment thread substrate/frame/broker/src/benchmarking.rs

ggwpez reviewed Jan 21, 2026

View reviewed changes

Comment thread substrate/frame/broker/src/benchmarking.rs

Address feedback

7885c4e

mertwole requested a review from ggwpez January 21, 2026 09:45

ggwpez approved these changes Jan 21, 2026

View reviewed changes

Comment thread prdoc/pr_10828.prdoc Outdated

Comment thread prdoc/pr_10828.prdoc Outdated

Adjust prdoc

ce513a9

github-actions Bot requested a review from ggwpez January 21, 2026 10:31

Merge branch 'master' into mertwole-add-remove-potential-renewal

73f4d7d

seadanda approved these changes Jan 22, 2026

View reviewed changes

Comment thread substrate/frame/broker/src/dispatchable_impls.rs Outdated

Resolve feedback

56094de

github-actions Bot requested a review from seadanda January 22, 2026 10:28

ggwpez approved these changes Jan 22, 2026

View reviewed changes

seadanda approved these changes Jan 22, 2026

View reviewed changes

seadanda added this pull request to the merge queue Jan 22, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 22, 2026

mertwole added this pull request to the merge queue Jan 22, 2026

Merged via the queue into master with commit 38e4741 Jan 22, 2026
238 of 241 checks passed

mertwole deleted the mertwole-add-remove-potential-renewal branch January 22, 2026 14:16

pgherveou added this to [preview] release tracker Mar 31, 2026

github-project-automation Bot moved this to Todo in [preview] release tracker Mar 31, 2026

github-project-automation Bot moved this from Todo to Done in [preview] release tracker Mar 31, 2026

Conversation

mertwole commented Jan 16, 2026

Uh oh!

mertwole commented Jan 16, 2026

Uh oh!

mertwole commented Jan 16, 2026

Uh oh!

command-bot Bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 16, 2026

Uh oh!

command-bot Bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot Bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot Bot commented Jan 16, 2026

Uh oh!

command-bot Bot commented Jan 16, 2026

Uh oh!

command-bot Bot commented Jan 16, 2026

Uh oh!

mertwole commented Jan 16, 2026

Uh oh!

github-actions Bot commented Jan 16, 2026

Uh oh!

github-actions Bot commented Jan 16, 2026

Uh oh!

mertwole commented Jan 16, 2026

Uh oh!

github-actions Bot commented Jan 16, 2026

Uh oh!

github-actions Bot commented Jan 16, 2026

Uh oh!

mertwole commented Jan 17, 2026

Uh oh!

mertwole commented Jan 17, 2026

Uh oh!

github-actions Bot commented Jan 17, 2026

Uh oh!

github-actions Bot commented Jan 17, 2026

Uh oh!

github-actions Bot commented Jan 17, 2026

Uh oh!

github-actions Bot commented Jan 17, 2026

Uh oh!

mertwole commented Jan 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ggwpez commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 21, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 21, 2026

Uh oh!

github-actions Bot commented Jan 21, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

command-bot Bot commented Jan 16, 2026 •

edited

Loading

command-bot Bot commented Jan 16, 2026 •

edited

Loading

command-bot Bot commented Jan 16, 2026 •

edited

Loading

ggwpez commented Jan 21, 2026 •

edited

Loading