Add tolerance to nom pool pending rewards try-state#1236
Merged
Conversation
liamaharon
added
the
T1-FRAME
Ank4n
reviewed
Aug 29, 2023
kianenigma
approved these changes
Sep 4, 2023
kianenigma
left a comment
kianenigma
left a comment
Contributor
There was a problem hiding this comment.
Reading the convo in https://github.com/paritytech/polkadot-sdk/pull/1236/files#r1308580829, I think this is one of those problem for which no ideal solution exists so I hope to accelerate either of the fixes by approving.
FWIW though, I think given the current way that this pallet is coded, the reward pools always having ED is actually NOT enforced, so instead of adding a tolerance to the check, the check should be strict, but it should only emit a warning instead of panicking.
…/fix-nom-pool-try-state
Contributor
Author
|
I have replaced the ensure check with a warning as suggested. |
Ank4n
approved these changes
Sep 12, 2023
1 task
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Closes paritytech#158 In our last FRAME call it was discussed that a likely solution to the ED imbalances is lazily fixing the pools as they are interacted with. So, we should add some tiny tolerance to the try-state checks so next time there's an ED change they don't start failing until they've all been interacted with. ### Update 12 Sept Rather than adding tolerance, have replaced the `ensure` with a warning. --------- Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #158
In our last FRAME call it was discussed that a likely solution to the ED imbalances is lazily fixing the pools as they are interacted with.
So, we should add some tiny tolerance to the try-state checks so next time there's an ED change they don't start failing until they've all been interacted with.
Update 12 Sept
Rather than adding tolerance, have replaced the
ensurewith a warning.