Skip to content

Merge CODEOWNERS Part 1#1472

Merged
bkchr merged 3 commits into
masterfrom
wk-230908-wk-230906-codeowners-simple
Sep 11, 2023
Merged

Merge CODEOWNERS Part 1#1472
bkchr merged 3 commits into
masterfrom
wk-230908-wk-230906-codeowners-simple

Conversation

@chevdor

@chevdor chevdor commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

This PR merged the previous CODEOWNERS files.

fix #1164

See also #1415

@chevdor chevdor added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Sep 8, 2023
@chevdor chevdor changed the title Merge CODEOWNERS Merge CODEOWNERS Part 1 Sep 8, 2023
@chevdor chevdor mentioned this pull request Sep 8, 2023
@paritytech-ci paritytech-ci requested review from a team September 8, 2023 15:00
@bkchr

bkchr commented Sep 9, 2023

Copy link
Copy Markdown
Member

@franciscoaguirre I added polkadot-sdk to the xcm team.

@franciscoaguirre

Copy link
Copy Markdown
Contributor

@bkchr I added the rule to the file, but it's still giving an error.
I think it's because we have only "read" access, we need "write" according to GitHub.

image

@bkchr

bkchr commented Sep 9, 2023

Copy link
Copy Markdown
Member

@bkchr I added the rule to the file, but it's still giving an error.
I think it's because we have only "read" access, we need "write" according to GitHub.

image

Fixed.

Comment thread .github/CODEOWNERS Outdated
@paritytech-ci paritytech-ci requested a review from a team September 11, 2023 08:38
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
@bkchr bkchr requested a review from alvicsam September 11, 2023 09:23
@bkchr bkchr merged commit cdf0de6 into master Sep 11, 2023
@bkchr bkchr deleted the wk-230908-wk-230906-codeowners-simple branch September 11, 2023 09:33
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
* Merge CODEOWNERS

* Add the XCM team as owner of /polkadot/xcm

* Update .github/CODEOWNERS

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

---------

Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
* Merge CODEOWNERS

* Add the XCM team as owner of /polkadot/xcm

* Update .github/CODEOWNERS

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

---------

Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup: CODEOWNERS file

5 participants