[xcm_builder]: Do not consume msg on NotApplicable for remote exporters#1519
Merged
Conversation
acatangiu
approved these changes
Sep 12, 2023
8 tasks
KiChjang
approved these changes
Sep 14, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementations of
SendXcm'svalidateshould not consumedestand/ormsgparameters in case ofNotApplicableerror according to this. This PR aligns expected behavior for UnpaidRemoteExporter and SovereignPaidRemoteExporter.Testing
Added
remote_exporters_does_not_consume_dest_or_msg_on_not_applicabletest which checks two possible cases:destis localdest