Skip to content

Enable runtime-benchmarks feature for crates#1544

Merged
muharem merged 3 commits into
masterfrom
muharem-forward-runtime-benchmarks-feature
Sep 14, 2023
Merged

Enable runtime-benchmarks feature for crates#1544
muharem merged 3 commits into
masterfrom
muharem-forward-runtime-benchmarks-feature

Conversation

@muharem

@muharem muharem commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

Enable runtime-benchmarks feature for parachain-common and cumulus-primitives-utility crates' dependencies.

After adding runtime-benchmarks = [] under features category in Cargo.toml files for the creates, I did run,

zepter lint propagate-feature --feature runtime-benchmarks --workspace --fix --feature-enables-dep="runtime-benchmarks:frame-benchmarking"

This changes required for #1333

@muharem muharem changed the title Forward runtime-benchmarks feature for parachain-common and cumulus-primitives-utility crates' dependencies Enable runtime-benchmarks feature for crates Sep 13, 2023
@muharem muharem added the T9-cumulus This PR/Issue is related to cumulus. label Sep 13, 2023
@muharem muharem marked this pull request as ready for review September 14, 2023 09:39
@muharem muharem requested review from a team and bkontur and removed request for a team September 14, 2023 09:42
@muharem muharem marked this pull request as draft September 14, 2023 09:56
@muharem muharem marked this pull request as ready for review September 14, 2023 09:58
@muharem

muharem commented Sep 14, 2023

Copy link
Copy Markdown
Contributor Author

bot merge

@command-bot

command-bot Bot commented Sep 14, 2023

Copy link
Copy Markdown

@muharem bot merge and bot rebase are not supported anymore. Please use native Github "Auto-Merge" and "Update Branch" buttons instead.
image

@muharem muharem merged commit 49c4b20 into master Sep 14, 2023
@muharem muharem deleted the muharem-forward-runtime-benchmarks-feature branch September 14, 2023 13:38
bkchr pushed a commit that referenced this pull request Apr 10, 2024
* TransactionInvalidationTracker

* TransacitonInvalidationTracker -> TransactionTracker

* change sign_transaction method

* clippy and spelling

* removed comment

* more transactiontracker tests

* stalls_when_transaction_tracker_returns_error

* remove test code

* remove "impl TransactionTracker for ()"

* enum TrackedTransactionStatus

* test TransactionTracker in on_transaction_status

* do_wait
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T9-cumulus This PR/Issue is related to cumulus.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants