polkadot: eradicate LeafStatus#1565
Merged
Merged
Conversation
ordian
added
A1-insubstantial
ordian
commented
Sep 14, 2023
Comment on lines
-424
to
-425
| // Only include bitfields on fresh leaves. On chain reversions, we want to make sure that | ||
| // there will be at least one block, which cannot get disputed, so the chain can make progress. |
Contributor
Author
There was a problem hiding this comment.
how do we ensure that?
Member
There was a problem hiding this comment.
By not including bitfields in the very first block after a reversion. If there are no bitfields, nothing can become included as of that block, hence it can not become a reversion target gain.
Member
There was a problem hiding this comment.
Given that the already existing leaf we are reverting to already exists, the stale/fresh mechanism should not be necessary to achieve this as we should not get that leaf activated again, hence nothing in parachain consensus is supposed to do anything -> paras inherent should be empty/not existing.
Contributor
Author
There was a problem hiding this comment.
Nice! So it works already 👍
BradleyOlson64
approved these changes
Oct 11, 2023
eskimor
approved these changes
Oct 16, 2023
Member
|
Tests would still be good for this. |
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* [BridgeHub] Added bridge-hub-rococo/wococo clients with bridge-hub-rococo-runtime * [BridgeHub] Add init-bridge stuff for bridge-hub-rococo/wococo * [BridgeHub] Add init-bridge stuff for bridge-hub-rococo/wococo * [BridgeHub] Fixed Call-encoding for init-bridge rococo runtime wrapper * Final index update to runtime calls * [BridgeHub] Add init-bridge stuff for bridge-hub-rococo/wococo (otherside) * Added runtime best_finalized functions + relay-headers init * Renaming and change BridgeHubRococo/Wococo to Rococo/Wococo config * [BridgeHub] Add relay-parachains (Rococo/Wococo) * Missing stuff for adding xcm messaging to BridgeHub * extracted parachain IDs to the primitives * fix compilation * Fixes * Init setup for Rococo->Wococo messaging support * Removed unused AccountId from `trait MessagesBridge` * Removed unused trait SenderOrigin * Small fixes * Cleaning after master-merge * Fixes * Fixes * Fixes * Fixes * Fixes: - align WeightToFee with BridgeHubRococo runtime - MAX_HEADER_SIZE - updated TODOs * Added relay_messages cfg for BridgeHubWococo -> BridgeHubRococo Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #768.