xcm-builder: PayOverXcm supports fallible convertors for asset kind and beneficiary conversion #1572
Merged
Merged
Conversation
KiChjang
approved these changes
Sep 16, 2023
acatangiu
approved these changes
Sep 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PayOverXcmtype accepts two converters to transform theAssetKindandBeneficiaryparameter types into recognizedxcmtypes. In this PR, we've modified the bounds for these converters, transitioning fromConverttoTryConvert.One such use case for this adjustment is when dealing with versioned xcm types for
AssetKindandBeneficiary. These types might be not convertible to the latest xcm version, hence the need for fallible conversion.This changes required for #1333