Add event field names to HRMP Event variants#1695
Merged
Merged
Conversation
seadanda
added
T2-pallets
Contributor
Author
|
Double checked e2e test syntax from https://github.com/paritytech/parachains-integration-tests for the two result changes. Happy to be reviewed now. |
franciscoaguirre
approved these changes
Sep 26, 2023
bkchr
approved these changes
Sep 27, 2023
gilescope
approved these changes
Sep 28, 2023
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the HRMP pallet to use field names for Event variants to improve metadata for a better client experience.
Event variants are now structs instead of unnamed tuples.
Tests and benchmarks are updated, and two integration test results are also updated.
Partially implements Substrate issue 9903 which doesn't appear to have been moved to the monorepo.