Skip to content

rpc/client: Propagate rpc_methods method to reported methods #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lexnv merged 2 commits into from
Sep 28, 2023
Merged

rpc/client: Propagate rpc_methods method to reported methods #1713

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a2b9dc
rpc/client: Propagate `rpc_methods` method to reported methods
lexnv Sep 26, 2023
e4e677f
rpc/client: Update comment
lexnv Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions substrate/client/rpc-servers/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@ fn hosts_filtering(enabled: bool, addrs: &[SocketAddr]) -> AllowHosts {

fn build_rpc_api<M: Send + Sync + 'static>(mut rpc_api: RpcModule<M>) -> RpcModule<M> {
let mut available_methods = rpc_api.method_names().collect::<Vec<_>>();
// The "rpc_methods" method name is guaranteed to not be registered in the rpc module
Comment thread
lexnv marked this conversation as resolved.
Outdated
// by `register_method`.
available_methods.push("rpc_methods");
available_methods.sort();

rpc_api
Expand Down