[xcm] Small enhancements for NetworkExportTable and xcm-builder#1848
Merged
Conversation
8 tasks
serban300
reviewed
Oct 11, 2023
Contributor
|
Thank you for splitting these changes in a separate PR ! They were much easier to review this way. |
…tFilter / XcmReserveTransferFilter`
serban300
approved these changes
Oct 16, 2023
franciscoaguirre
approved these changes
Oct 16, 2023
franciscoaguirre
left a comment
franciscoaguirre
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just left some nits
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Contributor
|
@paritytech/locks-review this small PR is already reviewed by bridges and xcm teams - needs |
bkchr
approved these changes
Oct 17, 2023
sandreim
approved these changes
Oct 17, 2023
tdimitrov
pushed a commit
that referenced
this pull request
Oct 23, 2023
…1848) ## Summary This PR introduces several enhancements. The current implementation of `NetworkExportTable` lacks remote location filtering support beyond `NetworkId` lookup. To provide more control and granularity, it's essential to allow configuration for bridging to different consensus `NetworkId` while restricting access e.g. to particular remote parachains. Additionally, the `StartsWith` and `Equals` and `StartsWithExplicitGlobalConsensus` helper functions, which are in active use, are moved to the `xcm-builder` and `frame_support` modules for better code organization. Adds a new `LocationWithAssetFilters` filter to enable location-based and asset-related filtering. This filter is useful for configuring the `pallet_xcm` filter for [XcmTeleportFilter](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/pallet-xcm/src/lib.rs#L212) and [XcmReserveTransferFilter](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/pallet-xcm/src/lib.rs#L216) to restrict specific assets. Furthermore, the `BridgeMessage` fields are not accessible outside of `xcm-builder`, limiting the ability to create custom logic dependent on it. --------- Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
svyatonik
added a commit
to svyatonik/runtimes
that referenced
this pull request
Nov 3, 2023
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
…aritytech#1848) ## Summary This PR introduces several enhancements. The current implementation of `NetworkExportTable` lacks remote location filtering support beyond `NetworkId` lookup. To provide more control and granularity, it's essential to allow configuration for bridging to different consensus `NetworkId` while restricting access e.g. to particular remote parachains. Additionally, the `StartsWith` and `Equals` and `StartsWithExplicitGlobalConsensus` helper functions, which are in active use, are moved to the `xcm-builder` and `frame_support` modules for better code organization. Adds a new `LocationWithAssetFilters` filter to enable location-based and asset-related filtering. This filter is useful for configuring the `pallet_xcm` filter for [XcmTeleportFilter](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/pallet-xcm/src/lib.rs#L212) and [XcmReserveTransferFilter](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/pallet-xcm/src/lib.rs#L216) to restrict specific assets. Furthermore, the `BridgeMessage` fields are not accessible outside of `xcm-builder`, limiting the ability to create custom logic dependent on it. --------- Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces several enhancements.
The current implementation of
NetworkExportTablelacks remote location filtering support beyondNetworkIdlookup. To provide more control and granularity, it's essential to allow configuration for bridging to different consensusNetworkIdwhile restricting access e.g. to particular remote parachains.Additionally, the
StartsWithandEqualsandStartsWithExplicitGlobalConsensushelper functions, which are in active use, are moved to thexcm-builderandframe_supportmodules for better code organization.Adds a new
LocationWithAssetFiltersfilter to enable location-based and asset-related filtering. This filter is useful for configuring thepallet_xcmfilter for XcmTeleportFilter and XcmReserveTransferFilter to restrict specific assets.Furthermore, the
BridgeMessagefields are not accessible outside ofxcm-builder, limiting the ability to create custom logic dependent on it.