Skip to content

pallet-vesting: Configurable block number provider#2403

Merged
bkchr merged 20 commits into
paritytech:masterfrom
arrudagates:gabriel-vesting_block_provider
Dec 11, 2023
Merged

pallet-vesting: Configurable block number provider#2403
bkchr merged 20 commits into
paritytech:masterfrom
arrudagates:gabriel-vesting_block_provider

Conversation

@arrudagates

@arrudagates arrudagates commented Nov 19, 2023

Copy link
Copy Markdown
Contributor

This PR makes the block number provider configurable through the Config trait in pallet-vesting, this gives parachains the option to use the relay chain block number provider from ParachainSystem.

@arrudagates arrudagates requested review from a team November 19, 2023 22:07
@paritytech-review-bot paritytech-review-bot Bot requested a review from a team November 19, 2023 22:07
@joepetrowski

joepetrowski commented Nov 20, 2023

Copy link
Copy Markdown
Contributor

bot fmt

@command-bot

command-bot Bot commented Nov 20, 2023 •
edited
Loading

Copy link
Copy Markdown

@joepetrowski https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4398815 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 68-f86e773d-01e1-4bd5-a2a6-ad0a2d5f7464 to cancel this command or bot cancel to cancel all commands in this pull request.

@joepetrowski joepetrowski added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Nov 20, 2023
@command-bot

command-bot Bot commented Nov 20, 2023

Copy link
Copy Markdown

@joepetrowski Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4398815 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4398815/artifacts/download.

joepetrowski
joepetrowski reviewed Nov 20, 2023
View reviewed changes
Comment thread polkadot/runtime/westend/src/lib.rs
@paritytech-ci paritytech-ci requested a review from a team November 20, 2023 06:35
@arrudagates

arrudagates commented Nov 20, 2023

Copy link
Copy Markdown
Contributor Author

These errors are not showing up when running the commands locally...

@bkchr bkchr requested a review from joepetrowski November 20, 2023 20:06
@bkchr

bkchr commented Nov 22, 2023

Copy link
Copy Markdown
Member

@arrudagates you still need to fix the benchmarking to use the BlockNumberProvider as well for the set_block_number calls.

@bkchr bkchr enabled auto-merge (squash) November 24, 2023 16:00
auto-merge was automatically disabled November 27, 2023 15:37

Merge queue setting changed

@bkchr

bkchr commented Dec 8, 2023

Copy link
Copy Markdown
Member

@arrudagates can you please add a prdoc as decribed here. Ty

ggwpez
ggwpez approved these changes Dec 9, 2023
View reviewed changes
Comment thread substrate/frame/vesting/src/lib.rs Outdated
@bkchr

bkchr commented Dec 11, 2023

Copy link
Copy Markdown
Member

@arrudagates please also add a prdoc as described here: https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/prdoc.md

@arrudagates

arrudagates commented Dec 11, 2023

Copy link
Copy Markdown
Contributor Author

@arrudagates please also add a prdoc as described here: https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/prdoc.md

Done.

bkchr
bkchr reviewed Dec 11, 2023
View reviewed changes
Comment thread prdoc/pr_2403.prdoc Outdated
@bkchr

bkchr commented Dec 11, 2023

Copy link
Copy Markdown
Member

@arrudagates the benchmarks for pallet-vesting are still failing. You should be able to reproduce this by running cargo test -p pallet-vesting --features runtime-benchmarks locally.

@bkchr bkchr merged commit c2d45e7 into paritytech:master Dec 11, 2023
@arrudagates arrudagates deleted the gabriel-vesting_block_provider branch December 13, 2023 13:09
@Polkadot-Forum

Polkadot-Forum commented Jan 26, 2024

Copy link
Copy Markdown

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-6-0/5855/1

bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 29, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#2403
5fa47d1
bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 29, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#2403
6c5e297
bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 30, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#2403
55c5985
bkontur added a commit to bkontur/runtimes that referenced this pull request Feb 3, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#2403
bec3793
bkontur added a commit to bkontur/runtimes that referenced this pull request Feb 3, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#2403
9f98634
bkontur added a commit to bkontur/runtimes that referenced this pull request Feb 6, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#2403
6fb51da
@github-actions github-actions Bot mentioned this pull request Feb 19, 2024
Closed
@github-actions github-actions Bot mentioned this pull request Mar 13, 2024
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@arrudagates @bkchr
pallet-vesting: Configurable block number provider (paritytech#2403)
0ca43f2 
This PR makes the block number provider configurable through the Config
trait in pallet-vesting, this gives parachains the option to use the
relay chain block number provider from ParachainSystem.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
@Aideepakchaudhary Aideepakchaudhary mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

Assignees

No one assigned

Labels

T1-FRAME This PR/Issue is related to core FRAME, the framework.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arrudagates @joepetrowski @bkchr @Polkadot-Forum @ggwpez @patriciobcs