Fix Stuck Collator Funds#4229
Merged
Merged
Conversation
joepetrowski
added
I2-bug
Co-authored-by: georgepisaltu <52418509+georgepisaltu@users.noreply.github.com>
ggwpez
reviewed
Apr 22, 2024
ggwpez
reviewed
Apr 22, 2024
ggwpez
reviewed
Apr 22, 2024
ggwpez
reviewed
Apr 22, 2024
ggwpez
reviewed
Apr 22, 2024
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 24, 2024
Fixes #4206 In #1340 one of the storage types was changed from `Candidates` to `CandidateList`. Since the actual key includes the hash of this value, all of the candidates stored here are (a) "missing" and (b) unable to unreserve their candidacy bond. This migration kills the storage values and refunds the deposit held for each candidate. --------- Signed-off-by: georgepisaltu <george.pisaltu@parity.io> Co-authored-by: georgepisaltu <52418509+georgepisaltu@users.noreply.github.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: georgepisaltu <george.pisaltu@parity.io>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 24, 2024
Fixes #4206 In #1340 one of the storage types was changed from `Candidates` to `CandidateList`. Since the actual key includes the hash of this value, all of the candidates stored here are (a) "missing" and (b) unable to unreserve their candidacy bond. This migration kills the storage values and refunds the deposit held for each candidate. --------- Signed-off-by: georgepisaltu <george.pisaltu@parity.io> Co-authored-by: georgepisaltu <52418509+georgepisaltu@users.noreply.github.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: georgepisaltu <george.pisaltu@parity.io>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 24, 2024
Fixes #4206 In #1340 one of the storage types was changed from `Candidates` to `CandidateList`. Since the actual key includes the hash of this value, all of the candidates stored here are (a) "missing" and (b) unable to unreserve their candidacy bond. This migration kills the storage values and refunds the deposit held for each candidate. --------- Signed-off-by: georgepisaltu <george.pisaltu@parity.io> Co-authored-by: georgepisaltu <52418509+georgepisaltu@users.noreply.github.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: georgepisaltu <george.pisaltu@parity.io>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 24, 2024
Fixes #4206 In #1340 one of the storage types was changed from `Candidates` to `CandidateList`. Since the actual key includes the hash of this value, all of the candidates stored here are (a) "missing" and (b) unable to unreserve their candidacy bond. This migration kills the storage values and refunds the deposit held for each candidate. --------- Signed-off-by: georgepisaltu <george.pisaltu@parity.io> Co-authored-by: georgepisaltu <52418509+georgepisaltu@users.noreply.github.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: georgepisaltu <george.pisaltu@parity.io>
This was referenced Apr 25, 2024
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 25, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 26, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 26, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 26, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev
added a commit
that referenced
this pull request
Apr 26, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 26, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 26, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/paritytech-update-for-april/7646/1 |
This was referenced Jun 5, 2024
Contributor
|
Can someone please explain to me why this fix is only part of SDK V1.11.0 and not any previous version? The error was introduced in v1.7.0 and should be backported to that version! On Centrifuge Chain, the v1 migration leads to collator candidates being removed from the session whitelist (i.e. |
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/paritytech-update-for-april-2024/7646/5 |
4 tasks
bkchr
pushed a commit
that referenced
this pull request
Jun 6, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
bkchr
pushed a commit
that referenced
this pull request
Jun 6, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
Contributor
Author
It was backported to 1.7: #4288 It was in the crates 10.0.2 release, e.g. as applied here: polkadot-fellows/runtimes#289 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4206
In #1340 one of the storage types was changed from
CandidatestoCandidateList. Since the actual key includes the hash of this value, all of the candidates stored here are (a) "missing" and (b) unable to unreserve their candidacy bond.This migration kills the storage values and refunds the deposit held for each candidate.