Skip to content

Para Inherent: filter v2 candidate descriptors#5362

Merged
sandreim merged 14 commits into
sandreim/rfc103-primitivesfrom
sandreim/filter_v2_descriptors
Aug 22, 2024
Merged

Para Inherent: filter v2 candidate descriptors#5362
sandreim merged 14 commits into
sandreim/rfc103-primitivesfrom
sandreim/filter_v2_descriptors

Conversation

@sandreim

@sandreim sandreim commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

On top of #5322

This is an additional check to prevent nodes from passing the v2 candidate descriptors in the runtime until it is enabled via the node feature.

TODO:

  • PRDoc

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@paritytech-cicd-pr

Copy link
Copy Markdown

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7015977

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

@alindima alindima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

Comment thread polkadot/primitives/src/vstaging/mod.rs
Comment thread polkadot/runtime/parachains/src/paras_inherent/mod.rs
Comment thread polkadot/runtime/parachains/src/paras_inherent/tests.rs Outdated
.
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim self-assigned this Aug 20, 2024
@alindima

Copy link
Copy Markdown
Contributor

I think you can merge this, since it's on the other branch also and it's hard to review without the context of the primitives PR.
Others can review it on that PR

@sandreim sandreim merged commit 1db5eb0 into sandreim/rfc103-primitives Aug 22, 2024
@sandreim sandreim deleted the sandreim/filter_v2_descriptors branch August 22, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Audited
Status: Completed

Development

Successfully merging this pull request may close these issues.

3 participants