[AHs] Support registering assets on Asset Hubs over bridge#5435
Merged
acatangiu merged 10 commits intoOct 17, 2024
Conversation
bkontur
approved these changes
Oct 14, 2024
| impl<AssetsAllowedNetworks: Contains<Location>, OriginLocation: Get<Location>> | ||
| ContainsPair<Asset, Location> for RemoteAssetFromLocation<AssetsAllowedNetworks, OriginLocation> | ||
| impl< | ||
| L: TryInto<Location> + Clone, |
Contributor
There was a problem hiding this comment.
maybe xcm::TryAs would also work here:
Suggested change
| L: TryInto<Location> + Clone, | |
| L: TryAs<Location>, |
so we don't need to clone anything here:
let Ok(asset) = asset.try_as() else {
return false;
};
let Ok(origin) = origin.try_as() else {
return false;
};
Contributor
Author
There was a problem hiding this comment.
the trait TryAs<cumulus_primitives_core::Location> is not implemented for cumulus_primitives_core::Location, which is required by `RemoteAssetFromLocation<AssetsAllowedNetworks, OriginLocation>: ContainsPair<cumulus_primitives_core::Location, cumulus_primitives_core::Location>
although it should work...
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5435-to-stable2407
git worktree add --checkout .worktree/backport-5435-to-stable2407 backport-5435-to-stable2407
cd .worktree/backport-5435-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 9714796ba9544f98c0361be466b9d993056aad50
git push --force-with-lease |
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
## Changes Allows one Asset Hub on one side, to register assets on the other Asset Hub over the bridge. Rococo <> Ethereum test bridge will be dropped in favor of Westend <> Ethereum test bridge. This PR also changes emulated tests to simulate double bridging from Ethereum<>Westend<>Rococo. ## Tests - [x] e2e test: Westend Asset Hub can register Westend and Ethereum assets on Asset Hub Rococo - [x] e2e test: Rococo Asset Hub can register Rococo assets on Asset Hub Westend - [x] e2e test (existing): Users on Ethereum can register Ethereum assets on Asset Hub Westend - [x] e2e test: transfer Rococo assets from Rococo to Westend and back - [x] e2e test: transfer Westend assets from Westend to Rococo and back - [x] e2e test: transfer Ethereum assets (bridged in through Snowbridge) from Westend to Rococo and back (cherry picked from commit 9714796)
Contributor
|
Successfully created backport PR for |
bkontur
had a problem deploying
to
subsystem-benchmarks
GitHub Actions
Failure
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Allows one Asset Hub on one side, to register assets on the other Asset Hub over the bridge.
Rococo <> Ethereum test bridge will be dropped in favor of Westend <> Ethereum test bridge. This PR also changes emulated tests to simulate double bridging from Ethereum<>Westend<>Rococo.
Tests